Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove ally.js #5226

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

chore: Remove ally.js #5226

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9957716
chore: Remove ally.js
mhuchet Mar 11, 2024
76f9b35
Merge branch 'master' into mhuchet/chore/remove-allyjs
mhuchet Apr 15, 2024
28d6acd
clean cdn stuff
mhuchet Apr 15, 2024
3566863
Merge branch 'master' into mhuchet/chore/remove-allyjs
mhuchet Apr 15, 2024
ed2b5a7
Merge branch 'master' into mhuchet/chore/remove-allyjs
mhuchet Jul 29, 2024
bdb4fed
put back cdn config for compat
mhuchet Jul 29, 2024
8cb5fc9
changeset
mhuchet Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 0 additions & 48 deletions fork/module-to-cdn/meta/ally.js/meta.json
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions fork/module-to-cdn/modules.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,15 +221,6 @@
}
}
},
"ally.js": {
"var": "ally",
"versions": {
">= 1.0.0": {
"development": "/ally.min.js",
"production": "/ally.min.js"
}
}
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would let it here in terms of backward compatiliby, in case you still have it in the code base it can break your app.
Remove it from the code and you should not have it anymore in the final application without this change.

"angular": {
"var": "angular",
"versions": {
Expand Down
1 change: 0 additions & 1 deletion packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
"@talend/react-a11y": "^3.0.1",
"@talend/react-bootstrap": "^2.2.2",
"@talend/utils": "^3.0.4",
"ally.js": "^1.4.1",
"classnames": "^2.5.1",
"d3": "^7.8.5",
"date-fns": "^3.3.1",
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/Badge/Badge.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ $tc-badge-disabled-opacity: 0.62;

&:hover,
&:focus,
&:global(.ally-focus-within) {
&:focus-within {
outline: none;
}
}
Expand Down Expand Up @@ -356,7 +356,7 @@ $tc-badge-disabled-opacity: 0.62;
&-dropdown {
.tc-badge-button {
&:not(.tc-badge-disabled) {
&:global(.ally-focus-within) {
&:focus-within {
border-color: tokens.$coral-color-accent-border;
}
}
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/Enumeration/Items/Item/Item.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,14 +118,14 @@ $item-checkbox-width: 20px;
}

.tc-enumeration-item:hover,
.tc-enumeration-item:global(.ally-focus-within) {
.tc-enumeration-item:focus-within {
.tc-enumeration-item-actions {
visibility: visible;
}
}

// disable hover if item is selected
.tc-enumeration-item:hover:not(.selected-item),
.tc-enumeration-item:not(.selected-item):global(.ally-focus-within) {
.tc-enumeration-item:not(.selected-item):focus-within {
background-color: tokens.$coral-color-neutral-background-medium;
}
2 changes: 1 addition & 1 deletion packages/components/src/Enumeration/Items/Items.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ $tc-enumeration-height: 40vh !default;

[role='row']:first-child {
&:hover,
&:global(.ally-focus-within) {
&:focus-within {
box-shadow: inset 0 21px 3px -20px $shadow;
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...s/components/src/List/Toolbar/ColumnChooserButton/ColumnChooser/ColumnChooser.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ $tc-height: 2.5rem;
border-bottom: $tc-popover-border-width solid tokens.$coral-color-neutral-border-weak;
}

&:global(.ally-focus-within),
&:focus-within,
&:hover {
background: tokens.$coral-color-neutral-background-medium;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/Status/Status.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ $tc-status-space-btn-icon-label: 5px !default;
}

&.action:hover,
&.action:global(.ally-focus-within) {
&.action:focus-within {
.tc-status-icon,
.tc-status-label {
opacity: 0;
Expand Down
1 change: 0 additions & 1 deletion packages/components/src/Status/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import '../polyfills/focus-within';
import { Status } from './Status.component';

export default Status;
12 changes: 6 additions & 6 deletions packages/components/src/VirtualizedList/CellTitle/CellTitle.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ $tc-list-title-icon-size: $svg-rg-size !default;
.tc-list-title-filter {
&:not(.tc-list-title-disabled) {
&:hover,
&:global(.ally-focus-within) {
&:focus-within {
.icon {
color: tokens.$coral-color-accent-text;
filter: none;
Expand All @@ -86,7 +86,7 @@ $tc-list-title-icon-size: $svg-rg-size !default;
:global(.ReactVirtualized__Table__row) {
&:hover,
&:focus,
&:global(.ally-focus-within) {
&:focus-within {
:global(.tc-list-title .cell-title-actions) {
opacity: 1;
width: 100%;
Expand All @@ -100,7 +100,7 @@ $tc-list-title-icon-size: $svg-rg-size !default;
:global(.ReactVirtualized__Table__row.active) {
&:hover,
&:focus,
&:global(.ally-focus-within) {
&:focus-within {
:global(.tc-list-title .cell-title-actions) {
// background: linear-gradient(90deg, tokens.$coral-color-neutral-background, tokens.$coral-color-accent-background $padding-large);
}
Expand All @@ -111,7 +111,7 @@ $tc-list-title-icon-size: $svg-rg-size !default;
:global(.ReactVirtualized__Table__row.selected) {
&:hover,
&:focus,
&:global(.ally-focus-within) {
&:focus-within {
:global(.tc-list-title .cell-title-actions) {
// background: linear-gradient(90deg, tokens.$coral-color-neutral-background, tokens.$coral-color-accent-background $padding-large);
}
Expand All @@ -125,7 +125,7 @@ $tc-list-title-icon-size: $svg-rg-size !default;
:global(.ReactVirtualized__Table__row) {
&:hover,
&:focus,
&:global(.ally-focus-within) {
&:focus-within {
overflow: visible !important;

:global(.tc-list-title-cell),
Expand All @@ -138,7 +138,7 @@ $tc-list-title-icon-size: $svg-rg-size !default;
:global(.ReactVirtualized__Table__row) {
&:hover,
&:focus,
&:global(.ally-focus-within) {
&:focus-within {
/* avoid scrolling over x axis */
width: auto !important;
right: 0 !important;
Expand Down
1 change: 0 additions & 1 deletion packages/components/src/VirtualizedList/CellTitle/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import '../../polyfills/focus-within';
import TitleColumn, { cellType, titleColumnConfiguration } from './TitleColumn.component';

export { cellType, TitleColumn };
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/VirtualizedList/ListTable/ListTable.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ $tc-list-table-cell-padding: $padding-small !default;

&:hover,
&:focus,
&:global(.ally-focus-within) {
&:focus-within {
background-color: tokens.$coral-color-neutral-background-medium;

.cell {
Expand Down
8 changes: 4 additions & 4 deletions packages/components/src/VirtualizedList/RowSelection/RowSelection.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

&:hover,
&:focus,
&:global(.ally-focus-within) {
&:focus-within {
background: tokens.$coral-color-accent-background-hover;
}
}
Expand All @@ -17,7 +17,7 @@

&:hover,
&:focus,
&:global(.ally-focus-within) {
&:focus-within {
background: tokens.$coral-color-accent-background-hover;
}
}
Expand All @@ -35,7 +35,7 @@

&:hover,
&:focus,
&:global(.ally-focus-within) {
&:focus-within {
background: tokens.$coral-color-accent-background-hover;
}
}
Expand All @@ -45,7 +45,7 @@

&:hover,
&:focus,
&:global(.ally-focus-within) {
&:focus-within {
background: tokens.$coral-color-accent-background-hover;
}
}
Expand Down
3 changes: 0 additions & 3 deletions packages/components/src/polyfills/focus-within.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/forms/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@
"@testing-library/jest-dom": "^6.4.2",
"@testing-library/react": "^14.2.1",
"@testing-library/user-event": "^14.5.2",
"ally.js": "^1.4.1",
"i18next": "^23.10.0",
"i18next-scanner-typescript": "^1.2.0",
"jest-in-case": "^1.0.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/theme/src/theme/_forms.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@
.radio-inline,
.checkbox,
.checkbox-inline {
&.ally-focus-within label {
&:focus-within label {
outline: none;
}
}
Expand Down
4 changes: 0 additions & 4 deletions tools/scripts-config-jest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
},
"peerDependencies": {
"@talend/design-system": ">= 8.1.0",
"ally.js": ">= 1.4.1",
"i18next": ">= 23.5.1",
"classnames": ">= 2.3.2",
"jest-axe": ">= 8.0.0",
Expand All @@ -48,9 +47,6 @@
"@talend/design-system": {
"optional": true
},
"ally.js": {
"optional": true
},
"classnames": {
"optional": true
},
Expand Down
4 changes: 0 additions & 4 deletions tools/scripts-config-jest/test-setup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@ try {
expect.extend(jestAxe.toHaveNoViolations);
} catch (e) {}

try {
jest.mock('ally.js');
} catch (e) {}

// add missing ResizeObserver
class ResizeObserver {
observe() {
Expand Down
1 change: 0 additions & 1 deletion versions/dependencies.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"angular": "^1.5.9",
"ag-grid-community": "^24.0.0",
"ag-grid-react": "^24.0.0",
"ally.js": "^1.4.1",
"babel-polyfill": "^6.26.0",
"popper.js": "1.16.1",
"ag-grid": "^24.0.0",
Expand Down
15 changes: 1 addition & 14 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5704,14 +5704,6 @@ all-contributors-cli@^6.26.1:
optionalDependencies:
prettier "^2"

ally.js@^1.4.1:
version "1.4.1"
resolved "https://registry.yarnpkg.com/ally.js/-/ally.js-1.4.1.tgz#9fb7e6ba58efac4ee9131cb29aa9ee3b540bcf1e"
integrity sha512-ZewdfuwP6VewtMN36QY0gmiyvBfMnmEaNwbVu2nTS6zRt069viTgkYgaDiqu6vRJ1VJCriNqV0jGMu44R8zNbA==
dependencies:
css.escape "^1.5.0"
platform "1.3.3"

ansi-colors@^4.1.1, ansi-colors@^4.1.3:
version "4.1.3"
resolved "https://registry.yarnpkg.com/ansi-colors/-/ansi-colors-4.1.3.tgz#37611340eb2243e70cc604cad35d63270d48781b"
Expand Down Expand Up @@ -7659,7 +7651,7 @@ css-what@^6.0.1, css-what@^6.1.0:
resolved "https://registry.yarnpkg.com/css-what/-/css-what-6.1.0.tgz#fb5effcf76f1ddea2c81bdfaa4de44e79bac70f4"
integrity sha512-HTUrgRJ7r4dsZKU6GjmpfRK1O76h97Z8MfS1G0FozR+oF2kG6Vfe8JE6zwrkbxigziPHinCJ+gCPjA9EaBDtRw==

css.escape@^1.5.0, css.escape@^1.5.1:
css.escape@^1.5.1:
version "1.5.1"
resolved "https://registry.yarnpkg.com/css.escape/-/css.escape-1.5.1.tgz#42e27d4fa04ae32f931a4b4d4191fa9cddee97cb"
integrity sha512-YUifsXXuknHlUsmlgyY0PKzgPOr7/FjCePfHNt0jxm83wHZi44VDMQ7/fGNkjY3/jV1MC+1CmZbaHzugyeRtpg==
Expand Down Expand Up @@ -14736,11 +14728,6 @@ pkg-dir@^7.0.0:
dependencies:
find-up "^6.3.0"

[email protected]:
version "1.3.3"
resolved "https://registry.yarnpkg.com/platform/-/platform-1.3.3.tgz#646c77011899870b6a0903e75e997e8e51da7461"
integrity sha512-VJK1SRmXBpjwsB4YOHYSturx48rLKMzHgCqDH2ZDa6ZbMS/N5huoNqyQdK5Fj/xayu3fqbXckn5SeCS1EbMDZg==

polished@^4.2.2:
version "4.3.1"
resolved "https://registry.yarnpkg.com/polished/-/polished-4.3.1.tgz#5a00ae32715609f83d89f6f31d0f0261c6170548"
Expand Down
Loading