chore: Remove ally.js #5226

mhuchet · 2024-03-11T16:45:59Z

What is the problem this PR is trying to solve?
We use ally.js to have a polyfill for :focus-within in css.

It is not really needed anymore as this pseudo class in now widely supported.

What is the chosen solution to this problem?
Remove ally.js polyfill and switch the usage of the lib css class to the pseudo class.

Please check if the PR fulfills these requirements

The PR have used yarn changeset to a request a release from the CI if wanted.
The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features) And non reg done before need review
Docs have been added / updated (for bug fixes / features)
Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

github-actions · 2024-04-15T09:25:24Z

5226

Demo is available here

github-actions · 2024-04-15T09:28:19Z

Title	Statements	Branches	Functions
assets-api	28.4% (25/88)	30.76% (16/52)	21.42% (3/14)
cmf	89.18% (1237/1387)	80.88% (605/748)	89.28% (350/392)
cmf-cqrs	87.43% (160/183)	70.23% (59/84)	84.21% (48/57)
cmf-router	69.23% (135/195)	55.71% (78/140)	56.81% (25/44)
components	90.79% (5521/6081)	81.85% (3198/3907)	88.2% (1391/1577)
containers	83.71% (1388/1658)	74.81% (692/925)	75.17% (327/435)
dataviz	85.44% (323/378)	66.66% (160/240)	75.79% (119/157)
design-system	66.75% (996/1492)	50.85% (536/1054)	54.54% (216/396)
faceted-search	85.69% (677/790)	79.37% (304/383)	82.63% (238/288)
flow-designer	70.07% (651/929)	66.72% (355/532)	70.92% (200/282)
forms	85.8% (1638/1909)	75.73% (927/1224)	84.24% (460/546)
http	100% (85/85)	98.07% (51/52)	100% (34/34)
sagas	92.3% (24/26)	66.66% (4/6)	50% (2/4)
stepper	81.52% (150/184)	59.34% (54/91)	80.85% (38/47)
utils	100% (73/73)	90.9% (10/11)	100% (24/24)

github-actions · 2024-04-15T09:31:15Z

Size Change: -1.89 kB (-0.01%)

Total Size: 16.9 MB

Filename	Size	Change
`./packages/components/dist/TalendReactComponents.css`	397 kB	-130 B (-0.03%)
`./packages/components/dist/TalendReactComponents.js`	4.73 MB	-1.18 kB (-0.02%)
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	3.04 kB	-170 B (-5.3%)	✅
`./packages/components/dist/TalendReactComponents.min.css`	211 kB	-130 B (-0.06%)
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	3.12 kB	-170 B (-5.17%)	✅
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json`	1.32 kB	-265 B (-16.71%)	👏
`./packages/theme/dist/bootstrap.css`	172 kB	+209 B (+0.12%)

ℹ️ View Unchanged

Filename	Size	Change
`./packages/assets-api/dist/TalendAssetsApi.js`	7.09 kB	0 B
`./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json`	2 B	0 B
`./packages/assets-api/dist/TalendAssetsApi.min.js`	3.32 kB	0 B
`./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json`	2 B	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	205 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	670 B	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	11.3 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	693 B	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js`	164 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json`	1.25 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js`	12.7 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json`	1.29 kB	0 B
`./packages/cmf/dist/TalendReactCmf.js`	505 kB	0 B
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	1.3 kB	0 B
`./packages/cmf/dist/TalendReactCmf.min.js`	65.1 kB	0 B
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	1.35 kB	0 B
`./packages/components/dist/TalendReactComponents.min.js`	1.26 MB	-48 B (0%)
`./packages/containers/dist/TalendReactContainers.css`	2.99 kB	0 B
`./packages/containers/dist/TalendReactContainers.js`	635 kB	0 B
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.4 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.css`	1.78 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.js`	92.8 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.45 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.css`	28.1 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.js`	371 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json`	1.15 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.css`	12.2 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.js`	59.5 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json`	1.18 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.css`	332 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.js`	1.37 MB	0 B
`./packages/design-system/dist/TalendDesignSystem.js.dependencies.json`	1.52 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.css`	215 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.js`	245 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json`	1.56 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.css`	79.1 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.js`	39.7 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json`	2 B	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.css`	75 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.js`	33.4 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json`	2 B	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.css`	19.1 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.js`	542 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json`	1.54 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.css`	6.28 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js`	100 kB	0 B
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js`	50.8 kB	0 B
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json`	1.25 kB	0 B
`./packages/forms/dist/TalendReactForms.css`	20.9 kB	0 B
`./packages/forms/dist/TalendReactForms.js`	1.46 MB	0 B
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.35 kB	0 B
`./packages/forms/dist/TalendReactForms.min.css`	6.2 kB	0 B
`./packages/forms/dist/TalendReactForms.min.js`	267 kB	0 B
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.39 kB	0 B
`./packages/http/dist/TalendHttp.js`	24.6 kB	0 B
`./packages/http/dist/TalendHttp.js.dependencies.json`	2 B	0 B
`./packages/http/dist/TalendHttp.min.js`	5.3 kB	0 B
`./packages/http/dist/TalendHttp.min.js.dependencies.json`	2 B	0 B
`./packages/icons/dist/bundle.js`	1.26 kB	0 B
`./packages/icons/dist/info.js`	26.8 kB	0 B
`./packages/icons/dist/react.esm.js`	614 kB	0 B
`./packages/icons/dist/react.js`	654 kB	0 B
`./packages/icons/dist/talend-icons-webfont.css`	18.3 kB	0 B
`./packages/icons/dist/talendicons.css`	334 B	0 B
`./packages/icons/dist/TalendIcons.js`	787 kB	0 B
`./packages/icons/dist/TalendIcons.js.dependencies.json`	128 B	0 B
`./packages/icons/dist/TalendIcons.min.js`	636 kB	0 B
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	131 B	0 B
`./packages/icons/dist/typeUtils.js`	14.5 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.js`	135 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json`	1.05 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.min.js`	21 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json`	1.07 kB	0 B
`./packages/sagas/dist/TalendReactSagas.js`	10.8 kB	0 B
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	349 B	0 B
`./packages/sagas/dist/TalendReactSagas.min.js`	1.41 kB	0 B
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	361 B	0 B
`./packages/stepper/dist/TalendReactStepper.css`	2.41 kB	0 B
`./packages/stepper/dist/TalendReactStepper.js`	97.9 kB	0 B
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	1.27 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.css`	1.2 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.js`	9.37 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	1.3 kB	0 B
`./packages/storybook-docs/dist/globalStyles.js`	0 B	0 B	🆕
`./packages/storybook-docs/dist/globalStyles.min.css`	384 B	0 B
`./packages/storybook-docs/dist/managerStyles.js`	0 B	0 B	🆕
`./packages/storybook-docs/dist/managerStyles.min.css`	1.5 kB	0 B
`./packages/theme/dist/bootstrap.js`	2.38 kB	0 B
`./packages/theme/dist/bootstrap.js.dependencies.json`	3 B	0 B

_{compressed-size-action}

jmfrancois · 2024-04-15T14:16:26Z

fork/module-to-cdn/modules.json

-  "ally.js": {
-    "var": "ally",
-    "versions": {
-      ">= 1.0.0": {
-        "development": "/ally.min.js",
-        "production": "/ally.min.js"
-      }
-    }
-  },


I would let it here in terms of backward compatiliby, in case you still have it in the code base it can break your app.
Remove it from the code and you should not have it anymore in the final application without this change.

jmfrancois

Also you need to add coresponding changeset

chore: Remove ally.js

9957716

mhuchet added the work in progress label Mar 11, 2024

mhuchet self-assigned this Mar 11, 2024

Merge branch 'master' into mhuchet/chore/remove-allyjs

76f9b35

mhuchet temporarily deployed to pull_request_unsafe April 15, 2024 09:16 — with GitHub Actions Inactive

clean cdn stuff

28d6acd

mhuchet temporarily deployed to pull_request_unsafe April 15, 2024 12:56 — with GitHub Actions Inactive

mhuchet added need review and removed work in progress labels Apr 15, 2024

Merge branch 'master' into mhuchet/chore/remove-allyjs

3566863

mhuchet temporarily deployed to pull_request_unsafe April 15, 2024 13:42 — with GitHub Actions Inactive

Gbacc approved these changes Apr 15, 2024

View reviewed changes

jmfrancois reviewed Apr 15, 2024

View reviewed changes

jmfrancois requested changes Apr 15, 2024

View reviewed changes

Merge branch 'master' into mhuchet/chore/remove-allyjs

ed2b5a7

mhuchet had a problem deploying to pull_request_unsafe July 29, 2024 08:52 — with GitHub Actions Error

put back cdn config for compat

bdb4fed

mhuchet temporarily deployed to pull_request_unsafe July 29, 2024 08:57 — with GitHub Actions Inactive

changeset

8cb5fc9

mhuchet temporarily deployed to pull_request_unsafe July 29, 2024 09:48 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Remove ally.js #5226

chore: Remove ally.js #5226

mhuchet commented Mar 11, 2024

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 15, 2024 •

edited

Loading

jmfrancois Apr 15, 2024

jmfrancois left a comment

chore: Remove ally.js #5226

Are you sure you want to change the base?

chore: Remove ally.js #5226

Conversation

mhuchet commented Mar 11, 2024

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024 • edited Loading

github-actions bot commented Apr 15, 2024 • edited Loading

jmfrancois Apr 15, 2024

Choose a reason for hiding this comment

jmfrancois left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 15, 2024 •

edited

Loading

github-actions bot commented Apr 15, 2024 •

edited

Loading