Change SetValue() return type to void

SleipnirGroup · Jul 3, 2024 · 03faa62 · 03faa62
1 parent 67dbac2
commit 03faa62
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 11 deletions.
diff --git a/include/sleipnir/autodiff/Variable.hpp b/include/sleipnir/autodiff/Variable.hpp
@@ -62,7 +62,7 @@ class SLEIPNIR_DLLEXPORT Variable {
    *
    * @param value The value of the Variable.
    */
-  Variable& SetValue(double value) {
+  void SetValue(double value) {
     if (expr->IsConstant(0.0)) {
       expr = detail::MakeExpressionPtr(value);
     } else {
@@ -76,7 +76,6 @@ class SLEIPNIR_DLLEXPORT Variable {
       }
       expr->value = value;
     }
-    return *this;
   }
 
   /**

diff --git a/include/sleipnir/autodiff/VariableBlock.hpp b/include/sleipnir/autodiff/VariableBlock.hpp
@@ -131,12 +131,10 @@ class VariableBlock {
    *
    * @param value Value to assign.
    */
-  VariableBlock<Mat>& SetValue(double value) {
+  void SetValue(double value) {
     Assert(Rows() == 1 && Cols() == 1);
 
     (*this)(0, 0).SetValue(value);
-
-    return *this;
   }
 
   /**
@@ -165,7 +163,7 @@ class VariableBlock {
    */
   template <typename Derived>
     requires std::same_as<typename Derived::Scalar, double>
-  VariableBlock<Mat>& SetValue(const Eigen::MatrixBase<Derived>& values) {
+  void SetValue(const Eigen::MatrixBase<Derived>& values) {
     Assert(Rows() == values.rows());
     Assert(Cols() == values.cols());
 
@@ -174,8 +172,6 @@ class VariableBlock {
         (*this)(row, col).SetValue(values(row, col));
       }
     }
-
-    return *this;
   }
 
   /**

diff --git a/include/sleipnir/autodiff/VariableMatrix.hpp b/include/sleipnir/autodiff/VariableMatrix.hpp
@@ -200,7 +200,7 @@ class SLEIPNIR_DLLEXPORT VariableMatrix {
    */
   template <typename Derived>
     requires std::same_as<typename Derived::Scalar, double>
-  VariableMatrix& SetValue(const Eigen::MatrixBase<Derived>& values) {
+  void SetValue(const Eigen::MatrixBase<Derived>& values) {
     Assert(Rows() == values.rows());
     Assert(Cols() == values.cols());
 
@@ -209,8 +209,6 @@ class SLEIPNIR_DLLEXPORT VariableMatrix {
         (*this)(row, col).SetValue(values(row, col));
       }
     }
-
-    return *this;
   }
 
   /**