Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #683: error when store_trace=true in OptimizationEvolutionary.jl #691

Merged
merged 8 commits into from
Feb 2, 2024
Merged

Fixed issue #683: error when store_trace=true in OptimizationEvolutionary.jl #691

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
20de7b2
Fixed `store_trace=true` bug
jonathanfischer97 Jan 31, 2024
2c62a8e
Merge pull request #1 from jonathanfischer97/dev
jonathanfischer97 Jan 31, 2024
f5d9db7
Merge branch 'SciML:master' into dev
jonathanfischer97 Feb 1, 2024
eef6558
Merge branch 'SciML:master' into master
jonathanfischer97 Feb 1, 2024
3658458
added test for `store_trace=true`. Passes on my branch, fails with er…
jonathanfischer97 Feb 1, 2024
bb4dede
Merge remote-tracking branch 'myfork/master' into dev
jonathanfischer97 Feb 1, 2024
985184b
removed commented out test_throws
jonathanfischer97 Feb 1, 2024
661bcf5
Merge pull request #2 from jonathanfischer97/dev
jonathanfischer97 Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/OptimizationEvolutionary/src/OptimizationEvolutionary.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
u = curr_u,
objective = x[1],
original = trace)
cb_call = cache.callback(opt_state, trace.value...)
cb_call = cache.callback(opt_state, decompose_trace(trace).value...)

Check warning on line 93 in lib/OptimizationEvolutionary/src/OptimizationEvolutionary.jl

View check run for this annotation

Codecov / codecov/patch

lib/OptimizationEvolutionary/src/OptimizationEvolutionary.jl#L93 

Added line #L93 was not covered by tests
if !(cb_call isa Bool)
error("The callback should return a boolean `halt` for whether to stop the optimization process.")
end
Expand Down
Loading