Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #683: error when store_trace=true in OptimizationEvolutionary.jl #691

Merged
merged 8 commits into from
Feb 2, 2024

Conversation

jonathanfischer97
Copy link
Contributor

Checklist

  • [NA] Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • [NA] All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • [NA] Any new documentation only uses public API

Additional context

Connected to issue #683 (comment)

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (28028fe) 8.62% compared to head (661bcf5) 8.62%.

Files Patch % Lines
...zationEvolutionary/src/OptimizationEvolutionary.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #691   +/-   ##
======================================
  Coverage    8.62%   8.62%           
======================================
  Files          31      31           
  Lines        2515    2515           
======================================
  Hits          217     217           
  Misses       2298    2298           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Vaibhavdixit02 Vaibhavdixit02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for the error you had seen before?

@jonathanfischer97
Copy link
Contributor Author

Can you add a test for the error you had seen before?

Will do!

@jonathanfischer97
Copy link
Contributor Author

@Vaibhavdixit02 added a test which fails on current version but passes on my fork.

Error "type Array has no field value" was thrown prior to my fix.

@ChrisRackauckas ChrisRackauckas merged commit a2ed16c into SciML:master Feb 2, 2024
39 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants