Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure to get RoomId in OnCloseGame callback #894

Merged
merged 1 commit into from
Jun 23, 2024
Merged

Fix failure to get RoomId in OnCloseGame callback #894

merged 1 commit into from
Jun 23, 2024

Commits on Jun 23, 2024

  1. Fix failure to get RoomId in OnCloseGame callback 

    There are some errors in the logs where the OnCloseGame callback of the
StateManagerPlugin is failing because there is no RoomId property.

This appears to happen if a player joins a game and it closes instantly,
typically due to connection issues. It seems in this case the code in
OnCreateGame which would initialize the RoomId does not have a chance to
run.

These headers are not required for the state manager or for Zena, and
are only used for recording time attack clears in GameLogicPlugin. So
the simplest thing to do is remove them.
    @SapiensAnatis
    SapiensAnatis committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    181895b View commit details
    Browse the repository at this point in the history