Fix failure to get RoomId in OnCloseGame callback #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some errors in the logs where the OnCloseGame callback of the StateManagerPlugin is failing because there is no RoomId property. This appears to happen if a player joins a game and it closes instantly, typically due to connection issues. It seems in this case the code in OnCreateGame which would initialize the RoomId does not have a chance to run. These headers are not required for the state manager or for Zena, and are only used for recording time attack clears in GameLogicPlugin. So the simplest thing to do is remove them.
SapiensAnatis
added a commit
that referenced
this pull request
Jun 30, 2024
There are some errors in the logs where the OnCloseGame callback of the StateManagerPlugin is failing because there is no RoomId property. This appears to happen if a player joins a game and it closes instantly, typically due to connection issues. It seems in this case the code in OnCreateGame which would initialize the RoomId does not have a chance to run. These headers are not required for the state manager or for Zena, and are only used for recording time attack clears in the main API (for requests originating from GameLogicPlugin). So the simplest thing to do is remove them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some errors in the logs where the OnCloseGame callback of the StateManagerPlugin is failing because there is no RoomId property.
This appears to happen if a player joins a game and it closes instantly, typically due to connection issues. It seems in this case the code in OnCreateGame which would initialize the RoomId does not have a chance to run.
These headers are not required for the state manager or for Zena, and are only used for recording time attack clears in the main API (for requests originating from GameLogicPlugin). So the simplest thing to do is remove them.