Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire mission progression events during story skip #847

Merged
merged 2 commits into from
May 30, 2024
Merged

Fire mission progression events during story skip #847

merged 2 commits into from
May 30, 2024

Commits on May 30, 2024

  1. Fire mission progression events during story skip 

    Closes #829. Ensure that we fire the corresponding mission events when
updating player state during the story skip process.

Also:
- Fix royal regimen displaying completed but unclaimed quests as active
- Minor naming nitpicks, micro-optimization of LINQ in StorySkipService
- Force braces for 1-line if statements after I read about `goto fail`

https://en.wikipedia.org/wiki/Unreachable_code#goto_fail_bug
    @SapiensAnatis
    SapiensAnatis committed May 30, 2024
    Configuration menu
    Copy the full SHA
    35aee2a View commit details
    Browse the repository at this point in the history

  2. csharpier

    @SapiensAnatis
    SapiensAnatis committed May 30, 2024
    Configuration menu
    Copy the full SHA
    5accb34 View commit details
    Browse the repository at this point in the history