Fire mission progression events during story skip #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #829. Ensure that we fire the corresponding mission events when updating player state during the story skip process. Also: - Fix royal regimen displaying completed but unclaimed quests as active - Minor naming nitpicks, micro-optimization of LINQ in StorySkipService - Force braces for 1-line if statements after I read about `goto fail` https://en.wikipedia.org/wiki/Unreachable_code#goto_fail_bug
SapiensAnatis
added a commit
that referenced
this pull request
Jun 30, 2024
Closes #829. Ensure that we fire the corresponding mission events when updating player state during the story skip process. Also: - Fix royal regimen displaying completed but unclaimed quests as active - Minor naming nitpicks, micro-optimization of LINQ in StorySkipService - Force braces for 1-line if statements after I read about `goto fail` https://en.wikipedia.org/wiki/Unreachable_code#goto_fail_bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #829. Ensure that we fire the corresponding mission events when updating player state during the story skip process.
Also:
goto failhttps://en.wikipedia.org/wiki/Unreachable_code#goto_fail_bug