-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge develop into master #384
Commits on Aug 7, 2023
-
DungeonRecordController refactor (#313)
- Have DungeonRecordController call into several services to build the giant response object. - Should enable easier unit testing and more extensibility - Add logic to show helper_list of co-op teammates when finishing a co-op quest
Configuration menu - View commit details
-
Copy full SHA for 910ea2d - Browse repository at this point
Copy the full SHA 910ea2dView commit details -
Fix server errors on quest completion and reset_new (#375)
- Fix crash on /dungeon_record/record where no quest entity - Fix null list crash on /update/reset_new
Configuration menu - View commit details
-
Copy full SHA for a52053e - Browse repository at this point
Copy the full SHA a52053eView commit details
Commits on Aug 9, 2023
-
Add party power calculation service (#374)
Co-authored-by: Nightmerp <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 388cb94 - Browse repository at this point
Copy the full SHA 388cb94View commit details -
Plugin retry fixes and refactoring (#377)
- Closes #244, a.k.a. [Golden Experience Requiem](https://www.youtube.com/watch?v=r_mfpy2ZyQQ) bug by returning players to the lobby when retrying after at least one player has given up. - Retries when failing a quest are still a bit glitchy -- it's supposed to remove players who voted no and allow players who voted yes to optionally rejoin the room similar to the prompt on a successful clear. Currently any retry where all players are dead will go back to the lobby. #378 raised to track. Plugin refactoring: - Remove HeroParam and other custom actor properties and persist this state in the plugin class, since only the plugin needs to know about these. It's tidier and avoids Photon having to serialize them (and crashing in the case of HeroParam since we didn't register this type). - Use enums for event codes. - Improve logging and add info logs which can provide basic diagnostics, particularly around potential problem areas such as GoToIngameState
Configuration menu - View commit details
-
Copy full SHA for 863d732 - Browse repository at this point
Copy the full SHA 863d732View commit details -
Fix failed retry votes on wipe (#380)
Closes #378 Correctly setting is_host from /dungeon/fail makes only the host call GameSucceed, and then the plugin can use the existing OnGameSucceed logic. Also sets support info correctly from this endpoint.
Configuration menu - View commit details
-
Copy full SHA for 6ee4a14 - Browse repository at this point
Copy the full SHA 6ee4a14View commit details
Commits on Aug 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c6b064b - Browse repository at this point
Copy the full SHA c6b064bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0397800 - Browse repository at this point
Copy the full SHA 0397800View commit details -
Configuration menu - View commit details
-
Copy full SHA for 640a641 - Browse repository at this point
Copy the full SHA 640a641View commit details