Merge develop into master #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Have DungeonRecordController call into several services to build the giant response object. - Should enable easier unit testing and more extensibility - Add logic to show helper_list of co-op teammates when finishing a co-op quest
- Fix crash on /dungeon_record/record where no quest entity - Fix null list crash on /update/reset_new
Co-authored-by: Nightmerp <[email protected]>
- Closes #244, a.k.a. [Golden Experience Requiem](https://www.youtube.com/watch?v=r_mfpy2ZyQQ) bug by returning players to the lobby when retrying after at least one player has given up. - Retries when failing a quest are still a bit glitchy -- it's supposed to remove players who voted no and allow players who voted yes to optionally rejoin the room similar to the prompt on a successful clear. Currently any retry where all players are dead will go back to the lobby. #378 raised to track. Plugin refactoring: - Remove HeroParam and other custom actor properties and persist this state in the plugin class, since only the plugin needs to know about these. It's tidier and avoids Photon having to serialize them (and crashing in the case of HeroParam since we didn't register this type). - Use enums for event codes. - Improve logging and add info logs which can provide basic diagnostics, particularly around potential problem areas such as GoToIngameState
Closes #378 Correctly setting is_host from /dungeon/fail makes only the host call GameSucceed, and then the plugin can use the existing OnGameSucceed logic. Also sets support info correctly from this endpoint.
SapiensAnatis
added a commit
that referenced
this pull request
Jun 30, 2024
Merge develop into master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.