Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️🔧 HOTFIX - Fix client side exception on home page #3129

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

Calinator444
Copy link
Member

@Calinator444 Calinator444 commented Sep 19, 2024

Description

Because the event banner does not have fallback behavior for when there is no upcoming event it will attempt to de-structure a null property if there is no upcoming event.

Changes

🔧 Live stream banner will not display if the event is null

Fixed Issue

Copy link
Contributor

github-actions bot commented Sep 19, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 0.22% 69/31192
🔴 Branches 7.59% 24/316
🔴 Functions 1.02% 3/295
🔴 Lines 0.22% 69/31192

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 649e8fa

@Calinator444 Calinator444 changed the title 🐛 Fixed live steam hook attempti ng to access props when liveStream i… ⚠️🔧 HOTFIX - Fix client side exception on home page Sep 19, 2024
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3129.azurewebsites.net

@amankumarrr amankumarrr merged commit dd3a5bd into main Sep 19, 2024
11 checks passed
@amankumarrr amankumarrr deleted the fix-bug-on-home-page branch September 19, 2024 01:45
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 65
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3129.azurewebsites.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ URGENT - Fix Client side exception on home page
2 participants