🐛 Megamenu - Fix mega menu not appearing on app router pages #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success13 tests passing in 1 suite. Report generated by 🧪jest coverage report action from 158cec1 |
|
Note: While working on this branch I discovered the scroll in animation for the live stream widget was broken on the app router pages |
|
Deployed changes to https://app-sswwebsite-9eb3-pr-3133.azurewebsites.net |
PageSpeed Insights
View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3133.azurewebsites.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a previous PR I added some fallback logic to ensure the live stream component wouldn't attempt to load if there was no upcoming event. However I didn't realize that the megamenu was being embedded in that component. Therefore whenever there's no upcoming livestream the megamenu wouldn't display.