Add GetFreeVariables() overload to Expression #22145
Merged
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have Expression::GetVariables() and Formula::GetFreeVariables(). In RobotLocomotion#22091, we could see that this difference (which is mostly unnecessary) made the downstream code unnecessarily clunky. This simple overload resolves it.
RussTedrake
added
release notes: feature
cohnt
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers
|
+@sammy-tri for platform review, please. |
sammy-tri
reviewed
Nov 11, 2024
There was a problem hiding this comment.
From looking at #22091 it's clear that this change improves readability there. I did a little digging to figure out if there was a deliberate reason for the different names and I couldn't immediately come up with anything. This has a slightly fishy smell to be but I can't figure out any reason to not merge it.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees sammy-tri(platform),cohnt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have Expression::GetVariables() and Formula::GetFreeVariables(). In #22091, we could see that this difference (which is mostly unnecessary) made the downstream code unnecessarily clunky. This simple overload resolves it.
+@cohnt for feature review, please.
This change is