Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for small-size LMI. #22143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hongkai-dai
Copy link
Contributor

@hongkai-dai hongkai-dai commented Nov 8, 2024

LMI with matrix size 1x1 and 2x2.


This change is Reviewable

LMI with matrix size 1x1 and 2x2.
Copy link
Contributor Author

@hongkai-dai hongkai-dai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@AlexandreAmice for feature review please, thanks!

Reviewable status: LGTM missing from assignee AlexandreAmice, needs platform reviewer assigned, needs at least two assigned reviewers, missing label for release notes (waiting on @hongkai-dai)

Copy link
Contributor

@AlexandreAmice AlexandreAmice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, missing label for release notes (waiting on @hongkai-dai)


solvers/test/mosek_solver_test.cc line 567 at r1 (raw file):

  MosekSolver solver;
  if (solver.available()) {
    Test2x2LMI(solver, 1E-7, /*check_dual=*/false, /*dual_tol=*/1E-7);

Do we not get the dual variables in mosek?

Copy link
Contributor Author

@hongkai-dai hongkai-dai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@xuchenhan-tri for platform review please, thanks!

Reviewable status: 1 unresolved discussion, LGTM missing from assignee xuchenhan-tri(platform), missing label for release notes (waiting on @hongkai-dai)


solvers/test/mosek_solver_test.cc line 567 at r1 (raw file):

Previously, AlexandreAmice (Alexandre Amice) wrote…

Do we not get the dual variables in mosek?

Not until #22144 is merged.

@xuchenhan-tri
Copy link
Contributor

@drake-jenkins-bot linux-jammy-gcc-bazel-experimental-debug please.

@xuchenhan-tri xuchenhan-tri added the release notes: none This pull request should not be mentioned in the release notes label Nov 13, 2024
Copy link
Contributor

@xuchenhan-tri xuchenhan-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+(release notes: none) :lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: 2 unresolved discussions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: none This pull request should not be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants