Fix exception message when center of mass is NAN. #22016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitiguy
added
priority: medium
status: do not review
release notes: fix
mitiguy
changed the title
mitiguy
commented
Oct 10, 2024
There was a problem hiding this comment.
Feature review +@sherm1
Reviewable status: LGTM missing from assignee sherm1(platform), needs at least two assigned reviewers
sherm1
reviewed
Oct 10, 2024
There was a problem hiding this comment.
I'm not clear on why this is needed -- let's discuss in the issue #22017
Reviewable status: LGTM missing from assignee sherm1(platform), needs at least two assigned reviewers
mitiguy
commented
Oct 12, 2024
There was a problem hiding this comment.
Done -- I added this to our discussion.
Reviewable status: LGTM missing from assignee sherm1(platform), needs at least two assigned reviewers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #22017
When an invalid center of mass (e.g., containing NAN or INF) is used in an SpatialInertia() constructor, a confusing exception message is issued, namely:
"CalcPrincipalMomentsAndMaybeAxesOfInertia(): Unable to calculate eigenvalues or eigenvectors of the 3x3 matrix associated with a RotationalInertia."
This PR creates a better message that more clearly communicate that the problem is with the center of mass position vector.
This change is