Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor user theme CSS to be provided by a stylesheet endpoint #1035

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Refactor user theme CSS to be provided by a stylesheet endpoint #1035

wants to merge 8 commits into from

Commits on Dec 20, 2023

  1. Refactor user theme CSS to be provided by a stylesheet endpoint

    @raccube
    raccube committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    aaf797e View commit details
    Browse the repository at this point in the history

  2. Set expiry of theme CSS to 3 months 

    The `ETag` from `fresh_when` takes care of cache busting here.
    @raccube
    raccube committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    9940398 View commit details
    Browse the repository at this point in the history

  3. Simplify theme helper

    @raccube
    raccube committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    c3a0455 View commit details
    Browse the repository at this point in the history

  4. Use static colour for Safari mask icon 

    This gets very aggressively cached so there isn't much of a point in making it respond to user themes as it doesn't always stay up to date.
    @raccube
    raccube committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    465f435 View commit details
    Browse the repository at this point in the history

  5. Add tests for user theme endpoint

    @raccube
    raccube committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    cfce343 View commit details
    Browse the repository at this point in the history

  6. Don't reassign @user 

    Co-authored-by: Georg Gadinger <[email protected]>
    @raccube @nilsding
    raccube and nilsding committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    e95ae7b View commit details
    Browse the repository at this point in the history

  7. Negate empty theme check 

    Co-authored-by: Georg Gadinger <[email protected]>
    @raccube @nilsding
    raccube and nilsding committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    1c18b96 View commit details
    Browse the repository at this point in the history

  8. Don't include theme CSS if there is no theme user present

    @raccube
    raccube committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    92b0382 View commit details
    Browse the repository at this point in the history