Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor user theme CSS to be provided by a stylesheet endpoint #1035

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

raccube
Copy link
Contributor

@raccube raccube commented Feb 1, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (855d0fa) 95.71% compared to head (92b0382) 95.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
- Coverage   95.71%   95.70%   -0.01%     
==========================================
  Files         174      174              
  Lines        2704     2701       -3     
==========================================
- Hits         2588     2585       -3     
  Misses        116      116              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

app/helpers/theme_helper.rb Outdated Show resolved Hide resolved
app/controllers/user_controller.rb Outdated Show resolved Hide resolved
app/controllers/user_controller.rb Show resolved Hide resolved
@raccube raccube marked this pull request as draft February 12, 2023 14:34
raccube and others added 8 commits December 20, 2023 11:45
The `ETag` from `fresh_when` takes care of cache busting here.
This gets very aggressively cached so there isn't much of a point in making it respond to user themes as it doesn't always stay up to date.
Co-authored-by: Georg Gadinger <[email protected]>
Co-authored-by: Georg Gadinger <[email protected]>
@raccube raccube marked this pull request as ready for review December 22, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants