Fixed compilation with cmake on Windows #16184
Open
+136
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kd-11
reviewed
Oct 7, 2024
oltolm
suggested changes
Oct 7, 2024
Megamouse
added
OS: Windows
Build and CI
|
I've added myself as reviewer because I need to verify that windows-on-arm build doesn't break here. There is no CI for it and I have to spin up an expensive cloud instance to compile it, so I'll only do that once it is ready. |
Megamouse
reviewed
Oct 9, 2024
Megamouse
reviewed
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmakeon Windows OSBUILDING.mdfile (sections related to Windows)Credits to @oltolm for the support here and on #16161
fixes #16161
PR STATUS: Ready for review and merge