Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Apple Clang and fix building on macOS Sonoma #14452

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nastys
Copy link
Contributor

@nastys nastys commented Aug 8, 2023

  • Fixes "old style cast" error when building using the macOS 14 SDK
  • Uses Apple's Clang compiler by default
  • The CI script can now be used as a local build script

@nastys nastys marked this pull request as ready for review August 8, 2023 09:18
@Megamouse Megamouse added OS: macOS Build and CI Anything related to the build process and continuous integration labels Aug 8, 2023
@nastys nastys marked this pull request as draft August 8, 2023 18:17
@nastys nastys marked this pull request as ready for review August 8, 2023 18:28
@nastys nastys marked this pull request as draft August 8, 2023 18:53
@nastys nastys marked this pull request as ready for review August 8, 2023 19:12
if [ ! -d "/tmp/Qt/$QT_VER" ]; then
mkdir -p "/tmp/Qt"
rm -rf qt-downloader
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why thou?
Maybe it would be better to check if dir exists and is git repo.

@@ -1,3 +1,7 @@
#if defined(__clang__)
#pragma clang diagnostic ignored "-Wold-style-cast"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think better to fix this by changing get<>Version methods to return static_cast<int>(osver.<>) instead of suppressing this warning.

@@ -4,6 +4,10 @@
#include <windows.h>

#elif defined(__APPLE__)
#if defined(__clang__)
#pragma clang diagnostic ignored "-Wold-style-cast"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think You're Holding It Wrong.
https://clang.llvm.org/docs/UsersManual.html#controlling-diagnostics-via-pragmas
You need to push, then ignore and finally pop before #elif defined(HAVE_QTDBUS) line

@pincetgore
Copy link

@nastys hi there! is it possible to resurrect this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build and CI Anything related to the build process and continuous integration OS: macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants