Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Apple Clang build #15240

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Fix Apple Clang build #15240

merged 1 commit into from
Feb 24, 2024

Conversation

RipleyTom
Copy link
Contributor

@RipleyTom RipleyTom commented Feb 24, 2024

Probably fixes #15239.

@shinra-electric
Copy link
Contributor

I tested this and can confirm it does allow the build to complete.

This seems to be the same workaround as in #14452, which is just to suppress the -Wold-style-cast warnings. Is this the preferred thing to do? Or would it be better to change the casts?

If suppressing the warning is fine, should I make a PR separate to Nastys' one that fixes the same issue on those other files? (That PR is larger and seems to have stalled).

@shinra-electric
Copy link
Contributor

For context, building from Master normally fails on Apple Clang, but I have a build script that adds in Nastys' workaround to the code before building.

@RipleyTom
Copy link
Contributor Author

RipleyTom commented Feb 24, 2024

We can't really change the casts as those are system or library headers.
Added the ones from Nastys' PR to this PR.

@Megamouse Megamouse added OS: macOS Build and CI Anything related to the build process and continuous integration labels Feb 24, 2024
@shinra-electric
Copy link
Contributor

We can't really change the casts as those are system or library headers. Added the ones from Nastys' PR to this PR.

Ok, I see.

I gave this a test and I'm getting a failure on display_sleep_control.cpp
Output (fail).txt

@RipleyTom
Copy link
Contributor Author

Should be fixed.

@shinra-electric
Copy link
Contributor

Yep, I can confirm it's fixed.

Thanks. 👍🏼

@elad335 elad335 merged commit 0f682b7 into RPCS3:master Feb 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build and CI Anything related to the build process and continuous integration OS: macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] [macOS] Build: Compilation fails on Apple Clang after #15185
4 participants