Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't panic when outputting TOML arrays in test failures. #28421

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Don't panic when outputting TOML arrays in test failures. #28421

merged 1 commit into from
Oct 23, 2024

Conversation

mikebenfield
Copy link
Collaborator 

TOML can't serialize arrays as the top level type.
Some of our test cases have TOML arrays as expected output.
Thus sometimes failed tests will panic when trying to report
expected and found output. Instead, we now manually "serialize"
TOML arrays.

@mikebenfield
Don't panic when outputting TOML arrays in test failures.
322f2f7 
TOML can't serialize arrays as the top level type.
Some of our test cases have TOML arrays as expected output.
Thus sometimes failed tests will panic when trying to report
expected and found output. Instead, we now manually "serialize"
TOML arrays.
d0cd
d0cd approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d0cd d0cd merged commit 1a2e5d9 into mainnet Oct 23, 2024
12 of 13 checks passed
@d0cd d0cd deleted the toml-output branch October 23, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d0cd d0cd d0cd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikebenfield @d0cd