Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't panic when outputting TOML arrays in test failures. #28421

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Don't panic when outputting TOML arrays in test failures. #28421

merged 1 commit into from
Oct 23, 2024

Commits on Oct 23, 2024

  1. Don't panic when outputting TOML arrays in test failures. 

    TOML can't serialize arrays as the top level type.
Some of our test cases have TOML arrays as expected output.
Thus sometimes failed tests will panic when trying to report
expected and found output. Instead, we now manually "serialize"
TOML arrays.
    @mikebenfield
    mikebenfield committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    322f2f7 View commit details
    Browse the repository at this point in the history