CI checkout SHA1 digests and work for both local and remote forks #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benoit Donneaux <[email protected]>
btlogy
force-pushed
the
462.ci-http-checkout
branch
from
2434ff6
to
6ef0159
Compare
added 2 commits
November 1, 2024 09:57
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
btlogy
force-pushed
the
462.ci-http-checkout
branch
from
1ac5922
to
47f350c
Compare
Signed-off-by: Benoit Donneaux <[email protected]>
btlogy
force-pushed
the
462.ci-http-checkout
branch
3 times, most recently
from
c17c1c6
to
172f5dd
Compare
Signed-off-by: Benoit Donneaux <[email protected]>
btlogy
force-pushed
the
462.ci-http-checkout
branch
from
172f5dd
to
25ea579
Compare
Signed-off-by: Benoit Donneaux <[email protected]>
btlogy
changed the title
|
I've tested this "logic" extensively (sorry for the possible noise) for both local and remote forks (see #474). |
This was referenced Nov 1, 2024
crwood
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #462
Since #467, CI checkout the code via https.
However, this has broken CI for builds triggered by PR from forks (vs branches within the project).
For instance here:
This PR should fix this by using the correct user and repo names (the remote/GitHub ones instead of the CircleCI ones).
In addition, the checkout will now use (and print) the SHA1 digest instead of the branch name.
This should also improve reproducibility by ensuring CircleCI builds the right thing.