Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Tahoe-LAFS version 1.17.1 #469

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Drop support for Tahoe-LAFS version 1.17.1 #469

merged 6 commits into from
Nov 1, 2024

Conversation

crwood
Copy link
Member

@crwood crwood commented Oct 31, 2024

Closes #468

@crwood
Copy link
Member Author

crwood commented Oct 31, 2024

Broken as a result of $CIRCLE_BRANCH pointing (in this case) to pull/469 instead of to 468.drop-tahoe-1.17 (introduced by #467).

cc @btlogy

@crwood crwood marked this pull request as ready for review October 31, 2024 19:39
hacklschorsch
hacklschorsch approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@hacklschorsch hacklschorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

btlogy
btlogy approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@btlogy btlogy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but probably interesting to rebase/merge once #473 lands main.

@crwood
Copy link
Member Author

crwood commented Nov 1, 2024

The failures above are unrelated to this PR; merging.

@crwood crwood merged commit 6939bc9 into PrivateStorageio:main Nov 1, 2024
7 of 13 checks passed
@crwood crwood deleted the 468.drop-tahoe-1.17 branch November 1, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btlogy btlogy btlogy approved these changes

@hacklschorsch hacklschorsch hacklschorsch approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Tahoe-LAFS version 1.17
3 participants
@crwood @hacklschorsch @btlogy