Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

mask prefect api key #341

Merged
merged 4 commits into from
Nov 27, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion prefect_aws/workers/ecs_worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,31 @@ def parse_identifier(identifier: str) -> ECSIdentifier:
return ECSIdentifier(cluster, task)


def mask_sensitive_env_values(
task_run_request: dict, values: list[str], keep_length=3, replace_with="***"
jakekaplan marked this conversation as resolved.
Show resolved Hide resolved
):
for container in task_run_request.get("overrides", {}).get(
"containerOverrides", []
):
for env_var in container.get("environment", []):
if (
"name" not in env_var
or "value" not in env_var
or env_var["name"] not in values
):
continue
if len(env_var["value"]) > keep_length:
# Replace characters beyond the keep length
env_var["value"] = env_var["value"][:keep_length] + replace_with
return task_run_request


def mask_api_key(task_run_request):
return mask_sensitive_env_values(
task_run_request, ["PREFECT_API_KEY"], keep_length=6
)


class ECSJobConfiguration(BaseJobConfiguration):
"""
Job configuration for an ECS worker.
Expand Down Expand Up @@ -718,8 +743,10 @@ def _create_task_and_wait_for_start(

logger.info("Creating ECS task run...")
logger.debug(
f"Task run request {json.dumps(task_run_request, indent=2, default=str)}"
"Task run request"
f"{json.dumps(mask_api_key(task_run_request), indent=2, default=str)}"
)

try:
task = self._create_task_run(ecs_client, task_run_request)
task_arn = task["taskArn"]
Expand Down
25 changes: 25 additions & 0 deletions tests/workers/test_ecs_worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
InfrastructureNotFound,
_get_container,
get_prefect_image_name,
mask_sensitive_env_values,
parse_identifier,
)

Expand Down Expand Up @@ -2031,3 +2032,27 @@ async def test_retry_on_failed_task_start(
await run_then_stop_task(worker, configuration, flow_run)

assert run_task_mock.call_count == 3


async def test_mask_sensitive_env_values():
task_run_request = {
"overrides": {
"containerOverrides": [
{
"environment": [
{"name": "PREFECT_API_KEY", "value": "SeNsItiVe VaLuE"},
{"name": "PREFECT_API_URL", "value": "NORMAL_VALUE"},
]
}
]
}
}

res = mask_sensitive_env_values(task_run_request, ["PREFECT_API_KEY"], 3, "***")
assert (
res["overrides"]["containerOverrides"][0]["environment"][0]["value"] == "SeN***"
)
assert (
res["overrides"]["containerOverrides"][0]["environment"][1]["value"]
== "NORMAL_VALUE"
)
Loading