Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

mask prefect api key #341

Merged
merged 4 commits into from
Nov 27, 2023
Merged

mask prefect api key #341

merged 4 commits into from
Nov 27, 2023

Conversation

jakekaplan
Copy link
Contributor

@jakekaplan jakekaplan commented Nov 21, 2023

closes: PrefectHQ/prefect#11098

Partially obscure PREFECT_API_KEY when we want to display the entire task run request for debug logging.

Screenshot 2023-11-21 at 10 10 10 AM

I'm also open to just removing the offending debugging logger statements

@jakekaplan jakekaplan requested a review from a team as a code owner November 21, 2023 15:11
Copy link
Contributor

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment about 3.8 compat but otherwise lgtm!

prefect_aws/workers/ecs_worker.py Outdated Show resolved Hide resolved
@jakekaplan jakekaplan merged commit 5735a49 into main Nov 27, 2023
6 checks passed
@jakekaplan jakekaplan deleted the mask-prefect-api-key branch November 27, 2023 20:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PREFECT_API_KEY exposed in flow run logs when running ECS Worker with DEBUG log level
3 participants