-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpp: export space and the set and map empty and universe constructors #11
Open
tobiasgrosser
wants to merge
5
commits into
PollyLabs:master
Choose a base branch
from
tobiasgrosser:export_space_and_set_map_constructors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
cpp: export space and the set and map empty and universe constructors #11
tobiasgrosser
wants to merge
5
commits into
PollyLabs:master
from
tobiasgrosser:export_space_and_set_map_constructors
Commits on Aug 18, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 3177d92 - Browse repository at this point
Copy the full SHA 3177d92View commit details -
Add isl_space_[set|map|params]_alloc_from_id_list
This allows the allocation of an isl_space with a list of parameter ids. As a result, the space that is returned contains parameter dimensions that are uniquely identified by an isl_id. Such parameter dimensions are also called named parameter dimensions. Named parameter dimensions are uniquely identified by the isl_id they reference and compare according to the rules for isl_ids (see manual): "Identifiers with the same name but different pointer values are considered to be distinct. Similarly, identifiers with different names but the same pointer value are also considered to be distinct. Equal identifiers are represented using the same object." Also add isl_space_[set|map]_noparams and isl_space_params_alloc_empty for the allocation of spaces without any parameters. These will later serve as convenience alternatives in the python/c++ interfaces, where the allocation functions that allow for the creation of unnamed parameter dimensions are not available. Signed-off-by: Tobias Grosser <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 367ad6a - Browse repository at this point
Copy the full SHA 367ad6aView commit details -
isl_space is a documented isl data type required to programmatically generate isl objects. It is required to generate empty and universe sets and maps. To construct an isl_space this commit also exports three allocators, isl_[set|map]_alloc_noparams and isl_params_alloc_empty that allow the convenient construction of spaces without parameter dimensions. These constructors are exported as unnamed constructors. This is according to the isl interface guidelines, as each given set of argument types uniquely identifies the constructed space. Hence, there is no ambiguity and an unnamed constructor can be used. Spaces with named parameter dimensions can currently be obtained by using isl::manage or isl::manage_copy. After isl_id and isl_id_list have been exposed additional constructors that allow construction with named parameter lists can be exposed. Signed-off-by: Tobias Grosser <[email protected]> Reviewed-by: Oleksandr Zinenko <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 180c633 - Browse repository at this point
Copy the full SHA 180c633View commit details -
cpp/python: export empty and universe constructors for sets
These functions are documented and commonly used when constructing isl sets. Export them for basic sets, sets, and union sets: isl_basic_set_empty isl_basic_set_universe isl_set_empty isl_set_universe isl_union_set_empty As the arguments of these constructors do not always uniquely identify the constructed object, named constructors are introduced according to the isl interface guidelines. Signed-off-by: Tobias Grosser <[email protected]> Reviewed-by: Oleksandr Zinenko <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7ce6b49 - Browse repository at this point
Copy the full SHA 7ce6b49View commit details -
cpp/python: export empty and universe constructors for maps
These functions are documented and commonly used when constructing isl maps. Export them for basic maps, maps, and union maps: isl_basic_map_empty isl_basic_map_universe isl_map_empty isl_map_universe isl_union_map_empty As the arguments of these constructors do not always uniquely identify the constructed object, named constructors are introduced according to the isl interface guidelines. Signed-off-by: Tobias Grosser <[email protected]> Reviewed-by: Oleksandr Zinenko <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7cc58a9 - Browse repository at this point
Copy the full SHA 7cc58a9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.