cpp: export space and the set and map empty and universe constructors #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasgrosser
changed the title
ftynse
approved these changes
Aug 3, 2017
|
CI itself seems broken.. |
tobiasgrosser
force-pushed
the
export_space_and_set_map_constructors
branch
3 times, most recently
from
32ffe24
to
422de74
Compare
|
CI is fixed. As I did not yet upstream the travis file, I need to include it in each PR. |
|
Proposed for inclusion on the isl mailing list. |
tobiasgrosser
force-pushed
the
export_space_and_set_map_constructors
branch
from
422de74
to
571a075
Compare
This allows the allocation of an isl_space with a list of parameter ids. As a result, the space that is returned contains parameter dimensions that are uniquely identified by an isl_id. Such parameter dimensions are also called named parameter dimensions. Named parameter dimensions are uniquely identified by the isl_id they reference and compare according to the rules for isl_ids (see manual): "Identifiers with the same name but different pointer values are considered to be distinct. Similarly, identifiers with different names but the same pointer value are also considered to be distinct. Equal identifiers are represented using the same object." Also add isl_space_[set|map]_noparams and isl_space_params_alloc_empty for the allocation of spaces without any parameters. These will later serve as convenience alternatives in the python/c++ interfaces, where the allocation functions that allow for the creation of unnamed parameter dimensions are not available. Signed-off-by: Tobias Grosser <[email protected]>
tobiasgrosser
force-pushed
the
export_space_and_set_map_constructors
branch
from
571a075
to
1d55124
Compare
isl_space is a documented isl data type required to programmatically generate isl objects. It is required to generate empty and universe sets and maps. To construct an isl_space this commit also exports three allocators, isl_[set|map]_alloc_noparams and isl_params_alloc_empty that allow the convenient construction of spaces without parameter dimensions. These constructors are exported as unnamed constructors. This is according to the isl interface guidelines, as each given set of argument types uniquely identifies the constructed space. Hence, there is no ambiguity and an unnamed constructor can be used. Spaces with named parameter dimensions can currently be obtained by using isl::manage or isl::manage_copy. After isl_id and isl_id_list have been exposed additional constructors that allow construction with named parameter lists can be exposed. Signed-off-by: Tobias Grosser <[email protected]> Reviewed-by: Oleksandr Zinenko <[email protected]>
These functions are documented and commonly used when constructing isl
sets. Export them for basic sets, sets, and union sets:
isl_basic_set_empty
isl_basic_set_universe
isl_set_empty
isl_set_universe
isl_union_set_empty
As the arguments of these constructors do not always uniquely identify
the constructed object, named constructors are introduced according to
the isl interface guidelines.
Signed-off-by: Tobias Grosser <[email protected]>
Reviewed-by: Oleksandr Zinenko <[email protected]>
These functions are documented and commonly used when constructing isl maps. Export them for basic maps, maps, and union maps: isl_basic_map_empty isl_basic_map_universe isl_map_empty isl_map_universe isl_union_map_empty As the arguments of these constructors do not always uniquely identify the constructed object, named constructors are introduced according to the isl interface guidelines. Signed-off-by: Tobias Grosser <[email protected]> Reviewed-by: Oleksandr Zinenko <[email protected]>
tobiasgrosser
force-pushed
the
export_space_and_set_map_constructors
branch
from
1d55124
to
7cc58a9
Compare
|
Hi @ftynse and others. I updated this pull request with the latest revision. We now have the following interface: This patch set exposes the constructors without parameter dimensions. For the second set of constructors we need isl_id and isl_id_list to be exported. Let me know your opinion. |
|
Why the names are The check/enforcement that ids actually have names will happen on the C++ side then? LGTM otherwise. |
That's a good point. I will suggest it as an alternative naming.
There is no need. Any isl_id that is constructed is "named". It either must have a name string or a pointer (which implicitly "names") it (at least in isl-speak).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export isl_space as well as empty and universe constructors for isl sets and maps.