Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd: update pd real cluster test #3168

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

okJiang
Copy link

@okJiang okJiang commented Oct 10, 2024

No description provided.

Signed-off-by: okJiang <[email protected]>
Copy link

ti-chi-bot bot commented Oct 10, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the changes made in this pull request are related to updating the PD real cluster test. However, there is no description of what specific updates have been made.

Looking at the diff, it appears that the changes involve modifying the paths to specific executable files. Specifically, it seems that the tikv-server, tidb-server, and tiflash files have been moved from third_bin to bin. However, in the updated test script, it is now looking for these files in third_bin instead of bin. This could cause issues with the test script not being able to find the necessary files.

A potential fix for this issue could be to update the script to look for the files in the correct directory (bin) or to move the files back to the original directory (third_bin). Additionally, it would be beneficial for the pull request author to provide a more detailed description of the changes made in the pull request.

Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

ti-chi-bot bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Oct 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-11 07:33:10.858156629 +0000 UTC m=+1204146.278369636: ☑️ agreed by purelind.

@purelind
Copy link
Collaborator

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants