-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refactor real cluster test and implement cluster id case #8685
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: okJiang <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
restartTiUP() | ||
checkLabelsAreEqual() | ||
} | ||
// func TestReloadLabel(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these cases will be updated with new style in the next pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think? Do I need update them in this pr? @rleungx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both are ok to me.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8685 +/- ##
==========================================
- Coverage 71.70% 71.66% -0.04%
==========================================
Files 517 517
Lines 67450 67454 +4
==========================================
- Hits 48364 48344 -20
- Misses 15521 15539 +18
- Partials 3565 3571 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
pull-integration-realcluster-test should be passed after PingCAP-QE/ci#3168 merge |
tests/integrations/realcluster/download_integration_test_binaries.sh
Outdated
Show resolved
Hide resolved
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
// --kv.binpath ./third_bin/tikv-server \ | ||
// --db.binpath ./third_bin/tidb-server --tiflash.binpath ./third_bin/tiflash \ | ||
--kv.binpath ./bin/tikv-server \ | ||
--db.binpath ./bin/tidb-server --tiflash.binpath ./bin/tiflash \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will use third_bin after PingCAP-QE/ci#3168 merge
What problem does this PR solve?
Issue Number: Close #8683, close #8684
What is changed and how does it work?
Check List
Tests
Release note