Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trait navigation to Volume button options #721

Merged
merged 6 commits into from
Sep 13, 2023
Merged

Conversation

bellerbrock
Copy link
Collaborator

@bellerbrock bellerbrock commented Aug 29, 2023

Description

Provide a summary of your changes including motivation and context.
If these changes fix a bug or resolves a feature request, be sure to link to that issue.

Converts volume button navigation setting from checkbox to list with 'Disabled', 'Trait Navigation', and 'Entry Navigation' as options.

closes #712

Type of change

What type of changes does your code introduce? Put an x in boxes that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated relevant documentation

Changelog entry

Please add a one-line changelog entry below. This will be copied to the changelog file during the release process.

Added trait navigation to volume button options

@trife
Copy link
Member

trife commented Sep 1, 2023

@bellerbrock update the summary with the selected option

@trife trife merged commit 36694b4 into main Sep 13, 2023
1 of 2 checks passed
@trife trife deleted the volume_button_options branch September 13, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volume button remap option
2 participants