Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xlsx formula fix for field import files #657

Merged
merged 2 commits into from
Jul 10, 2023
Merged

xlsx formula fix for field import files #657

merged 2 commits into from
Jul 10, 2023

Conversation

chaneylc
Copy link
Member

@chaneylc chaneylc commented Jul 5, 2023

Description

XLSX formulas weren't being evaluated when imported.

Type of change

What type of changes does your code introduce? Put an x in boxes that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated relevant documentation

Changelog entry

Please add a one-line changelog entry below. This will be copied to the changelog file during the release process.

Support for formulas in XLSX files.

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

🤖 Pull request artifacts

file commit
pr657-1-xlsx_formula_fix-Field-Book.apk cd4da6a

github-actions bot added a commit that referenced this pull request Jul 5, 2023
github-actions bot added a commit that referenced this pull request Jul 7, 2023
@trife
Copy link
Member

trife commented Jul 10, 2023

closes #658

@trife trife merged commit c4275bf into main Jul 10, 2023
1 check passed
@trife trife deleted the issue/xlsx_formula_fix branch July 10, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants