Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed search box so text entry field is visible #654

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

joegage
Copy link

@joegage joegage commented Jul 5, 2023

Description

The search feature in Collection had spinners centered in the screen, pushing the text entry field out of view, so it was not possible to search:

image

I modified the box layout by giving the spinners and the text field equal weights. This seems pulls the text field back into visibility.

I am not an experienced Android developer, so I don't know if this is the best way to accomplish this. Maybe there is another, preferred way!

image

Type of change

What type of changes does your code introduce? Put an x in boxes that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated relevant documentation

Changelog entry

Please add a one-line changelog entry below. This will be copied to the changelog file during the release process.


@chaneylc
Copy link
Member

chaneylc commented Jul 5, 2023

Hey @joegage thanks for the PR, can you share what type of device and android os you're using? I am not able to reproduce this problem on a Pixel 6 API 33 device, thanks.

@joegage
Copy link
Author

joegage commented Jul 5, 2023

Ah, interesting - we have this issue with our physical devices (Moto Play G, 2021, Android 11) - the search screen looks just like in the emulator screencap above. The emulator I'm using is Pixel 6 API 30, also running Android 11.

@trife
Copy link
Member

trife commented Jul 10, 2023

@joegage I'm going to merge this in for now but will hopefully redo search into it's own window at some point in the future. Thanks for the contribution!

@all-contributors add @joegage code

@allcontributors
Copy link
Contributor

@trife

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @joegage! 🎉

@trife trife merged commit 5f109e6 into PhenoApps:main Jul 10, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants