code improvement

PhenoApps · Jul 12, 2023 · 7143d28 · 7143d28
1 parent eb8381a
commit 7143d28
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/app/src/main/java/com/fieldbook/tracker/activities/ConfigActivity.java b/app/src/main/java/com/fieldbook/tracker/activities/ConfigActivity.java
@@ -115,9 +115,8 @@ public class ConfigActivity extends ThemedActivity {
     @Inject
     public DataHelper database;
     @Inject
-    public FieldSwitchImpl fieldSwitcher;
-    @Inject
     public SoundHelperImpl soundHelper;
+    public FieldSwitchImpl fieldSwitcher = null;
     Handler mHandler = new Handler();
     boolean doubleBackToExitPressedOnce = false;
     ListView settingsList;
@@ -341,6 +340,9 @@ private void loadScreen() {
                     .initiateScan();
         });
 
+        //this must happen after migrations and can't be injected in config
+        fieldSwitcher = new FieldSwitchImpl(this);
+
     }
 
     /**
@@ -991,6 +993,10 @@ public void selectFirstField() {
      */
     private void switchField(int studyId) {
 
+        if (fieldSwitcher == null) {
+            fieldSwitcher = new FieldSwitchImpl(this);
+        }
+
         fieldSwitcher.switchField(studyId);
 
     }

diff --git a/app/src/main/java/com/fieldbook/tracker/utilities/FieldSwitchImpl.kt b/app/src/main/java/com/fieldbook/tracker/utilities/FieldSwitchImpl.kt
@@ -22,6 +22,9 @@ class FieldSwitchImpl @Inject constructor(@ActivityContext private val context:
     }
 
     override fun switchField(studyId: Int) {
+        if (!::database.isInitialized) {
+            database = DataHelper(context)
+        }
         val f = database.getFieldObject(studyId)
         switchField(f)
     }