Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 3.8, fix integration test #328

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Drop support for Python 3.8, fix integration test #328

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67ebfd3
Drop 3.8
mudit2812 Aug 22, 2023
0b5a317
Update CHANGELOG.md
mudit2812 Aug 22, 2023
32822d0
Updated test
mudit2812 Aug 22, 2023
d321506
Merge branch 'master' into drop3.8
mudit2812 Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/format.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: 3.8
python-version: 3.9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 3.9 vs more recent versions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no strong reason. i guess we know 3.9 still works?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I'm just wondering if we could make these changes easier next time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo it's just a matter of convention, but I'd be happy to skip to the max python version we support whenever we drop support for the version used in CI. change every 3-4 releases instead of every release!


- name: Install dependencies
run: pip install black
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:

strategy:
matrix:
python-version: [3.8, 3.9, '3.10', '3.11']
python-version: [3.9, '3.10', '3.11']

steps:
- name: Cancel Previous Runs
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@

### Breaking changes 💔

* Support for Python 3.8 has been removed.
[(#328)](https://github.com/PennyLaneAI/pennylane-qiskit/pull/328)

### Deprecations 👋

### Documentation 📝
Expand All @@ -16,6 +19,8 @@

This release contains contributions from (in alphabetical order):

Mudit Pandey

---
# Release 0.31.0

Expand Down
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ Features
Installation
============

This plugin requires Python version 3.8 and above, as well as PennyLane and Qiskit.
This plugin requires Python version 3.9 and above, as well as PennyLane and Qiskit.
Installation of this plugin, as well as all dependencies, can be done using ``pip``:

.. code-block:: bash
Expand Down
1 change: 0 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@
"Operating System :: Microsoft :: Windows",
"Programming Language :: Python",
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
'Programming Language :: Python :: 3.11',
Expand Down
1 change: 0 additions & 1 deletion tests/test_runtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ def circuit(theta, phi):
"kwargs",
[
{
"initial_layout": [0, 1],
"layout_method": "trivial",
"routing_method": "basic",
"translation_method": "translator",
Expand Down
Loading