Drop support for Python 3.8, fix integration test #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudit2812
commented
Aug 22, 2023
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 314 314
=========================================
Hits 314 314 |
timmysilv
approved these changes
Aug 22, 2023
timmysilv
changed the title
trbromley
reviewed
Aug 24, 2023
| @@ -14,7 +14,7 @@ jobs: | |||
| - name: Set up Python | |||
| uses: actions/setup-python@v2 | |||
| with: | |||
| python-version: 3.8 | |||
| python-version: 3.9 | |||
There was a problem hiding this comment.
Why 3.9 vs more recent versions?
There was a problem hiding this comment.
no strong reason. i guess we know 3.9 still works?
There was a problem hiding this comment.
Sounds good, I'm just wondering if we could make these changes easier next time.
There was a problem hiding this comment.
imo it's just a matter of convention, but I'd be happy to skip to the max python version we support whenever we drop support for the version used in CI. change every 3-4 releases instead of every release!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As name says