-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.8, fix integration test #328
Conversation
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 314 314
=========================================
Hits 314 314 |
@@ -14,7 +14,7 @@ jobs: | |||
- name: Set up Python | |||
uses: actions/setup-python@v2 | |||
with: | |||
python-version: 3.8 | |||
python-version: 3.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 3.9 vs more recent versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no strong reason. i guess we know 3.9 still works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I'm just wondering if we could make these changes easier next time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo it's just a matter of convention, but I'd be happy to skip to the max python version we support whenever we drop support for the version used in CI. change every 3-4 releases instead of every release!
As name says