Implement get_c_interface method for Kokkos plugin #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #837 +/- ##
===========================================
- Coverage 98.53% 80.99% -17.55%
===========================================
Files 116 17 -99
Lines 18510 1936 -16574
===========================================
- Hits 18239 1568 -16671
- Misses 271 368 +97 ☔ View full report in Codecov by Sentry. |
rauletorresc
force-pushed
the
raultorres/kokkos_get_c_interface
branch
from
7a66cb2
to
120962b
Compare
rauletorresc
force-pushed
the
raultorres/kokkos_get_c_interface
branch
from
c39d1cd
to
6d7d6a3
Compare
maliasadi
requested changes
Aug 5, 2024
There was a problem hiding this comment.
Thanks @rauletorresc for adding the missing get_c_interface method to LK 💯
vincentmr
reviewed
Aug 5, 2024
There was a problem hiding this comment.
Otherwise looks good to me. Some tests would be nice if possible as pointed out by @maliasadi . Ping me again for another round of reviews.
rauletorresc
force-pushed
the
raultorres/kokkos_get_c_interface
branch
from
39ca4ad
to
6e2fca1
Compare
rauletorresc
force-pushed
the
raultorres/kokkos_get_c_interface
branch
2 times, most recently
from
74298ff
to
f72140e
Compare
rauletorresc
force-pushed
the
raultorres/kokkos_get_c_interface
branch
2 times, most recently
from
ba1fb09
to
cdb46a7
Compare
rauletorresc
force-pushed
the
raultorres/kokkos_get_c_interface
branch
6 times, most recently
from
7f5de01
to
d00bd5a
Compare
rauletorresc
force-pushed
the
raultorres/kokkos_get_c_interface
branch
from
d00bd5a
to
181daf2
Compare
maliasadi
approved these changes
Aug 7, 2024
vincentmr
approved these changes
Aug 7, 2024
rauletorresc
added a commit
to PennyLaneAI/catalyst
that referenced
this pull request
Aug 8, 2024
**Context:** Lightning Kokkos plugin has been migrated to Lightning. We can remove its code from Catalyst then. But this PR in Lightning must be approved first: PennyLaneAI/pennylane-lightning#837 **Description of the Change:** Remove plugin from code and from the list of provided plugins. **Benefits:** Remove duplicated functionality. [sc-69450] --------- Co-authored-by: David Ittah <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Catalyst is removing the Kokkos plugin from its code base (PennyLaneAI/catalyst#974) and is attempting to use it directly from Lightning. However, the C interface was not provided via Python.
Description of the Change: Implement the C interface provider method in Python.
Benefits: Catalyst can use the Kokkos plugin.