-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement get_c_interface method for Kokkos plugin #837
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #837 +/- ##
===========================================
- Coverage 98.53% 80.99% -17.55%
===========================================
Files 116 17 -99
Lines 18510 1936 -16574
===========================================
- Hits 18239 1568 -16671
- Misses 271 368 +97 ☔ View full report in Codecov by Sentry. |
7a66cb2
to
120962b
Compare
c39d1cd
to
6d7d6a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rauletorresc for adding the missing get_c_interface
method to LK 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks good to me. Some tests would be nice if possible as pointed out by @maliasadi . Ping me again for another round of reviews.
39ca4ad
to
6e2fca1
Compare
74298ff
to
f72140e
Compare
ba1fb09
to
cdb46a7
Compare
7f5de01
to
d00bd5a
Compare
d00bd5a
to
181daf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @rauletorresc!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @rauletorresc !
**Context:** Lightning Kokkos plugin has been migrated to Lightning. We can remove its code from Catalyst then. But this PR in Lightning must be approved first: PennyLaneAI/pennylane-lightning#837 **Description of the Change:** Remove plugin from code and from the list of provided plugins. **Benefits:** Remove duplicated functionality. [sc-69450] --------- Co-authored-by: David Ittah <[email protected]>
Context: Catalyst is removing the Kokkos plugin from its code base (PennyLaneAI/catalyst#974) and is attempting to use it directly from Lightning. However, the C interface was not provided via Python.
Description of the Change: Implement the C interface provider method in Python.
Benefits: Catalyst can use the Kokkos plugin.