-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Lightning Kokkos plugin #974
Conversation
Is this approach correct? |
50fc116
to
6d9457d
Compare
That looks right to me. The next step is updating the lightning-kokkos dependency to a recent dev wheel and checking whether we can run all our tests. Actually, I'm wondering whether the PR that moved the plugin also ensured the plugin was distributed with the their wheels. I guess we will find out 😅 |
This is the lightning PR: |
e165276
to
2142907
Compare
Removing the wheel build label until we've finished repairing the actions. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #974 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 75 75
Lines 10548 10548
Branches 1216 1216
=======================================
Hits 10329 10329
Misses 172 172
Partials 47 47 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love to see it! Let's wait until the lightning PR is merged and also until we can test all wheel configurations, but this has my preliminary approval :)
Just waiting on the lightning PR to finish testing these changes 👍 |
**Context:** Catalyst is removing the Kokkos plugin from its code base (PennyLaneAI/catalyst#974) and is attempting to use it directly from Lightning. However, the C interface was not provided via Python. **Description of the Change:** Implement the C interface provider method in Python. **Benefits:** Catalyst can use the Kokkos plugin. --------- Co-authored-by: ringo-but-quantum <[email protected]>
ae4c431
to
f333109
Compare
f333109
to
e4faa8b
Compare
Context: Lightning Kokkos plugin has been migrated to Lightning. We can remove its code from Catalyst then. But this PR in Lightning must be approved first: PennyLaneAI/pennylane-lightning#837
Description of the Change: Remove plugin from code and from the list of provided plugins.
Benefits: Remove duplicated functionality.
[sc-69450]