Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Github action ternary op & expand wheel support #765

Merged
merged 8 commits into from
Jun 18, 2024

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Jun 17, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: This PR aims to fix the issue encountered by https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/9555317980

Description of the Change: "" -> '' and parenthesis around ternary op components. Expands supports to MacOS (x64/arm64) and Linux aarch64 too.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-66316]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.08%. Comparing base (bc8db8d) to head (bd6660b).
Report is 94 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (bc8db8d) and HEAD (bd6660b). Click for more details.

HEAD has 26 uploads less than BASE
Flag BASE (bc8db8d) HEAD (bd6660b)
31 5
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #765       +/-   ##
===========================================
- Coverage   95.24%   58.08%   -37.16%     
===========================================
  Files         122       17      -105     
  Lines       17741     1904    -15837     
===========================================
- Hits        16897     1106    -15791     
+ Misses        844      798       -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlxd mlxd marked this pull request as ready for review June 17, 2024 22:15
@mlxd mlxd requested review from maliasadi and dime10 June 17, 2024 22:16
.github/workflows/wheel_linux_x86_64.yml Outdated Show resolved Hide resolved
@mlxd mlxd changed the title Fix Github action ternary op Fix Github action ternary op & expand wheel support Jun 18, 2024
.github/workflows/wheel_linux_aarch64.yml Outdated Show resolved Hide resolved
.github/workflows/wheel_macos_arm64.yml Outdated Show resolved Hide resolved
.github/workflows/wheel_macos_x86_64.yml Outdated Show resolved Hide resolved
.github/CHANGELOG.md Outdated Show resolved Hide resolved
@dime10 dime10 merged commit a790d02 into master Jun 18, 2024
46 of 47 checks passed
@dime10 dime10 deleted the bugfix/ghaction_ternary_lk branch June 18, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants