Skip to content

Commit

Permalink
Fix Github action ternary op & expand wheel support (#765)
Browse files Browse the repository at this point in the history
### Before submitting

Please complete the following checklist when submitting a PR:

- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
      [`tests`](../tests) directory!

- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
      render correctly by running `make docs`.

- [ ] Ensure that the test suite passes, by running `make test`.

- [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
      change, and including a link back to the PR.

- [ ] Ensure that code is properly formatted by running `make format`. 

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


------------------------------------------------------------------------------------------------------------

**Context:** This PR aims to fix the issue encountered by
https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/9555317980

**Description of the Change:** "" -> '' and parenthesis around ternary
op components. Expands supports to MacOS (x64/arm64) and Linux aarch64
too.

**Benefits:**

**Possible Drawbacks:**

**Related GitHub Issues:**

---------

Co-authored-by: ringo-but-quantum <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
  • Loading branch information
3 people authored Jun 18, 2024
1 parent bc8db8d commit a790d02
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 12 deletions.
5 changes: 4 additions & 1 deletion .github/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@

### Improvements

* LightningKokkos dev wheels are pushed to https://test.pypi.org/project/PennyLane-Lightning-Kokkos/ upon PR merge.
* LightningKokkos dev wheels for MacOS (x86_64, ARM64) and Linux (aarch64) are uploaded to TestPyPI upon PR merge.
[(#765)](https://github.com/PennyLaneAI/pennylane-lightning/pull/765)

* LightningKokkos Linux (x86_64) dev wheels are pushed to https://test.pypi.org/project/PennyLane-Lightning-Kokkos/ upon PR merge.
[(#763)](https://github.com/PennyLaneAI/pennylane-lightning/pull/763)

* Change the type of tensor network objects passed to `ObservablesTNCuda` and `MeasurementsTNCuda` class from `StateTensorT` to `TensorNetT`.
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/wheel_linux_aarch64.yml
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ jobs:
strategy:
matrix:
arch: [aarch64]
pl_backend: ["lightning_qubit"]
pl_backend: ["lightning_qubit", "lightning_kokkos"]
runs-on: ubuntu-latest

if: |
Expand All @@ -190,5 +190,5 @@ jobs:
uses: pypa/gh-action-pypi-publish@release/v1
with:
user: __token__
password: ${{ secrets.TEST_PYPI_API_TOKEN }}
repository-url: https://test.pypi.org/legacy/
password: ${{ ( matrix.pl_backend == 'lightning_qubit' ) && secrets.TEST_PYPI_API_TOKEN || secrets.TEST_PYPI_LKOKKOS_TOKEN }}
repository-url: https://test.pypi.org/legacy/
2 changes: 1 addition & 1 deletion .github/workflows/wheel_linux_x86_64.yml
Original file line number Diff line number Diff line change
Expand Up @@ -216,5 +216,5 @@ jobs:
uses: pypa/gh-action-pypi-publish@release/v1
with:
user: __token__
password: ${{ matrix.pl_backend == "lightning_qubit" && secrets.TEST_PYPI_API_TOKEN || secrets.TEST_PYPI_LKOKKOS_TOKEN }}
password: ${{ ( matrix.pl_backend == 'lightning_qubit' ) && secrets.TEST_PYPI_API_TOKEN || secrets.TEST_PYPI_LKOKKOS_TOKEN }}
repository-url: https://test.pypi.org/legacy/
6 changes: 3 additions & 3 deletions .github/workflows/wheel_macos_arm64.yml
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ jobs:
strategy:
matrix:
arch: [arm64]
pl_backend: ["lightning_qubit"]
pl_backend: ["lightning_qubit", "lightning_kokkos"]
runs-on: ubuntu-latest

if: |
Expand All @@ -144,5 +144,5 @@ jobs:
uses: pypa/gh-action-pypi-publish@release/v1
with:
user: __token__
password: ${{ secrets.TEST_PYPI_API_TOKEN }}
repository-url: https://test.pypi.org/legacy/
password: ${{ ( matrix.pl_backend == 'lightning_qubit' ) && secrets.TEST_PYPI_API_TOKEN || secrets.TEST_PYPI_LKOKKOS_TOKEN }}
repository-url: https://test.pypi.org/legacy/
6 changes: 3 additions & 3 deletions .github/workflows/wheel_macos_x86_64.yml
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ jobs:
strategy:
matrix:
arch: [x86_64]
pl_backend: ["lightning_qubit"]
pl_backend: ["lightning_qubit", "lightning_kokkos"]
runs-on: ubuntu-latest

if: |
Expand All @@ -199,5 +199,5 @@ jobs:
uses: pypa/gh-action-pypi-publish@release/v1
with:
user: __token__
password: ${{ secrets.TEST_PYPI_API_TOKEN }}
repository-url: https://test.pypi.org/legacy/
password: ${{ ( matrix.pl_backend == 'lightning_qubit' ) && secrets.TEST_PYPI_API_TOKEN || secrets.TEST_PYPI_LKOKKOS_TOKEN }}
repository-url: https://test.pypi.org/legacy/
2 changes: 1 addition & 1 deletion pennylane_lightning/core/_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@
Version number (major.minor.patch[-label])
"""

__version__ = "0.37.0-dev39"
__version__ = "0.37.0-dev40"

0 comments on commit a790d02

Please sign in to comment.