-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Dockerfile robustness #722
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #722 +/- ##
==========================================
+ Coverage 92.73% 97.72% +4.98%
==========================================
Files 92 68 -24
Lines 13777 9309 -4468
==========================================
- Hits 12776 9097 -3679
+ Misses 1001 212 -789 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Jason Selby <[email protected]>
…ane-lightning into update/kokkos_version
Seems to work well now (test) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @vincentmr! Don't forget to update the changelog.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
When PennyLane lags Lightning, like around release dates, there is a possibility that Docker images for Lightning will be built before PennyLane is release and hence the versions mismatch.
Description of the Change:
Add PENNYLANE_VERSION build arg.
Remove dependency on requirement files and install only deps that are needed.
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-63094]