Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dockerfile robustness #722

Merged
merged 47 commits into from
Jun 20, 2024
Merged

Improve Dockerfile robustness #722

merged 47 commits into from
Jun 20, 2024

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented May 10, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
When PennyLane lags Lightning, like around release dates, there is a possibility that Docker images for Lightning will be built before PennyLane is release and hence the versions mismatch.

Description of the Change:
Add PENNYLANE_VERSION build arg.
Remove dependency on requirement files and install only deps that are needed.

Benefits:

Possible Drawbacks:

Related GitHub Issues:
[sc-63094]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (d9da016) to head (268aaed).
Report is 92 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
+ Coverage   92.73%   97.72%   +4.98%     
==========================================
  Files          92       68      -24     
  Lines       13777     9309    -4468     
==========================================
- Hits        12776     9097    -3679     
+ Misses       1001      212     -789     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
@vincentmr vincentmr marked this pull request as ready for review May 15, 2024 13:16
.github/workflows/docker_linux_x86_64.yml Outdated Show resolved Hide resolved
.github/workflows/docker_linux_x86_64.yml Outdated Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
Makefile Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
@vincentmr vincentmr mentioned this pull request May 16, 2024
5 tasks
@vincentmr
Copy link
Contributor Author

Seems to work well now (test)

docker/Dockerfile Outdated Show resolved Hide resolved
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @vincentmr! Don't forget to update the changelog.

docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
@vincentmr vincentmr merged commit edd4515 into master Jun 20, 2024
87 checks passed
@vincentmr vincentmr deleted the update/dockerfile branch June 20, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants