Pandabrick encoders #216
Merged
Pandabrick encoders #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Encoder loss deduced from serial data from encoder not clock * Loss detection common to master and sniffer * For BiSS, just check for clock at startup as CRC will check data * integrity. Serial clock is needed to interpret data frame.
…nts" This reverts commit 3510835.
tomtrafford
force-pushed
the
pandabrick-encoders
branch
from
b403037
to
9944ee1
Compare
glennchid
previously approved these changes
Oct 11, 2024
glennchid
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to split PandABrick encoders into ABSENC, INCENC and PMACENC. Step Direction on PMACENC still needs to be implemented and an issue has been made for this #204.
Resolves #184