Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move const q under Constants #558

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KronosTheLate
Copy link
Contributor

This PR moves the definition of the constant q under "Constants". See #556.

I also changed the comment on the line defining q from "e means 2.718..." to "avoid naming conflict with e", as I feel the original phrasing could be confused with the e in the line that means "times 10 to the power of..."

This PR moves the definition of the constant `q` under "Constants". See [556](PainterQubits#556)

I also changed the comment on the line defining `q` from "`e` means 2.718..." to "avoid naming conflict with `e`", as I feel the original phrasing could be confused with the `e` in the line that means "times 10 to the power of..."
@sostock
Copy link
Collaborator

sostock commented Sep 14, 2022

You only moved the definition of q. The definition of eV needs to be moved as well, since it uses q.

@KronosTheLate
Copy link
Contributor Author

Nice catch @sostock. However, eV is not a constant, but a unit. So I will move it to under the "constants" section, right?

@j-fu
Copy link

j-fu commented Sep 14, 2022

Once you are working on the constants: are you aware of #545 ?

@KronosTheLate
Copy link
Contributor Author

not at all

@sostock
Copy link
Collaborator

sostock commented Sep 14, 2022

However, eV is not a constant, but a unit. So I will move it to under the "constants" section, right?

IMO, you can also move it into the constants section (right below q), since there are other units that are defined in that section as well (c, u).

@KronosTheLate
Copy link
Contributor Author

That is not an argument to move eV into the constants section, but rather c and u out of it IMO.

@sostock
Copy link
Collaborator

sostock commented Oct 9, 2022

That’s fine too, although I like that the units are defined immediately after the constants on which they are based.

@KronosTheLate
Copy link
Contributor Author

There is sone appeal, but I personally look up the variables for constants all the time, and love having them all in one place. So that has more weight to me, as I frequently make use of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants