Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unitful.q not under consts in file #556

Open
KronosTheLate opened this issue Sep 12, 2022 · 2 comments
Open

Unitful.q not under consts in file #556

KronosTheLate opened this issue Sep 12, 2022 · 2 comments

Comments

@KronosTheLate
Copy link
Contributor

In the file defining constants, the elementary charge is not defined under "constants".
image

image

This confused me. Any reason why?
@sostock
Copy link
Collaborator

sostock commented Sep 12, 2022

Probably not. It is used to define the unit eV, but that definition could also be defined in the "Constants" section (as other units like c already are).

KronosTheLate added a commit to KronosTheLate/Unitful.jl that referenced this issue Sep 12, 2022
@KronosTheLate
Move const q under Constants
482acb9 
This PR moves the definition of the constant `q` under "Constants". See [556](PainterQubits#556)

I also changed the comment on the line defining `q` from "`e` means 2.718..." to "avoid naming conflict with `e`", as I feel the original phrasing could be confused with the `e` in the line that means "times 10 to the power of..."
@KronosTheLate KronosTheLate mentioned this issue Sep 12, 2022
Open
@KronosTheLate
Copy link
Contributor Author

I fixed it in #558.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sostock @KronosTheLate