feat(hardware): add acceleration args to LLD #16665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanthecoder
force-pushed
the
EXEC-746-add-acceleration-args
branch
from
62ce849
to
ef52632
Compare
ryanthecoder
force-pushed
the
EXEC-746-add-acceleration-args
branch
from
ef52632
to
e43de49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We want to start experimenting with acceleration so add an acceleration argument to the lld settings, it's defaulted to 0 everywhere but this lets us add it to testing scripts to try out.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment