chore(shared-data): Add definition for 96ch v3.6 with 3.0mm backlash #14682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes RQA-2459 Do not instantiate new notification ipcRenderer event listeners for each component that intends to subscribe to the notification server. Instead re-use the same ipcRenderer listener. This not only reduces the number of emitters created, but fixes a bug in which ipcRenderer listeners were not properly disposed.
RQA-2496 This "attach gripper" button text wasn't capitalized. Now it is.
Closes RQA-2312 We previously swallowed collision errors during fast home move and proceeded to slow home because we used to not handle encoder overflow properly and would mistakenly raise. Now that we have fixed those encoder issues, we should actually raise the error when the motor stalls.
# Overview User-facing app and robot release notes for v7.2.1. Addresses RTC-405. # Review requests Coherent, correct, and complete? # Risk assessment No risk. --------- Co-authored-by: Edward Cormany <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.2.1 #14682 +/- ##
====================================================
Coverage 67.56% 67.56%
====================================================
Files 2521 2521
Lines 72251 72251
Branches 9311 9311
====================================================
Hits 48815 48815
Misses 21240 21240
Partials 2196 2196
Flags with carried forward coverage won't be shown. Click here to find out more. |
andySigler
deleted the
chore-add-shared-data-96ch-model-v3.6-for-increased-backlash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Increased backlash compensation improves low-volume performance.
NOTE: not ready to merge until accuracy functions have been updated
Test Plan
Changelog
Review requests
Risk assessment