fix(api): FLEX fast home collision hangs because of deadlock #14602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.2.0 #14602 +/- ##
====================================================
Coverage 67.57% 67.57%
====================================================
Files 2521 2521
Lines 72237 72237
Branches 9306 9306
====================================================
Hits 48816 48816
Misses 21226 21226
Partials 2195 2195
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ahiuchingau
deleted the
RQA-2312-bug-flex-home-gantry-does-not-respond-after-a-previous-collision-during-home-gantry
branch
y3rsh
pushed a commit
that referenced
this pull request
Mar 13, 2024
y3rsh
pushed a commit
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RQA-2312
Overview
When a stall happens during a FLEX fast home move, it tries to acquire the motion lock while trying to refresh position - while it already has the lock and causes the robot to hang.