-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: 7.1.0 mergeback into edge from Alpha.7 #14198
Conversation
--------- Co-authored-by: Seth Foster <[email protected]>
refetches the deck config on a 5 second interval on the device details page and in hooks that determine location conflicts closes RQA-1993
* fix(app): fix styling of read-only deck configurator closes RQA-1987
* feat(app): add deck config option to device reset
…LPC (#14126) Uses the new verify tip presence command to check that the calibration probe is present where relevant instead of getting tip status data from /instruments. --------- Co-authored-by: Seth Foster <[email protected]>
updates pipetteNameSpecs flowRates to match version 2 definitions
…and (#14139) Drop tip flows require saving pipette positions without homing the plunger axis (we definitely do not want to home the plunger). The save_position command should optionally expose a failOnNotHomed parameter to prevent an error from being thrown when the plunger is not homed.
…14133) * Delete unused stuff in _waste_chute_dimensions. * Delete unused with_staging_area_slot_d4 arg.
filters the labware location combos generated by getLabwareLocationCombos by Flex or OT-2 single slot addressable area name, to exclude labware in staging area slots as LPC options closes RQA-1989
…view (#14149) fixes several TODOs that were left in the Protocol Engine AddressableAreaStore and AddressableAreaView during initial development
* fix(app): remove probe check from module cal Module calibration doesn't require a pipette id and thus none is available here (and in general I believe you can do it with a gripper) so this isn't really an appropriate check. * this was new too whoops probably should have been a sign
… container structure (#14145) Fixes issues introduced to 2,16 protocols for OT2 and 2,15 and prior protocols for OT2 and Flex
adds the necessary processing to useDeckConfigurationCompatibility to surface a required protocol single slot fixture conflict and provide the missing on-deck labware display name for that single slot. updates ODD FixtureTable to fix a location conflict modal bug where incorrect data was shown in the modal when multiple location conflicts exist closes RAUT-885, RQA-1985
* fix(app): fix module calibration selection slot issue
…iner not being a Labware anymore (#14171) * Delete dead code. * Account for .trash_container being a non-Labware.
) Closes RQA-2013 Clicking the error banner within ProtcolRunHeader has the behavior of clearing the current run, but this behavior is not desired. First, it actually unrenders the error banner, and second, all conditional rendering tied to the current run (such as the drop tip banner) are unrendered as well.
replaces the existing fixture conflict chevron with a resolve or configure button closes RAUT-900
* fix(app): fix dqa ODD protocol setup deck config
…while maintaining OT2 behavior (#14182) Removes the automatic drop tip behavior from do_stop_and_recover for Flex protocols while retaining OT2 behavior
* fix(app): fix module calibration wizard copy
* fix(components): fix storybook deck configurator
* fix(app): update error messaging for module calibration fix RQA-2084
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #14198 +/- ##
==========================================
+ Coverage 70.39% 70.47% +0.08%
==========================================
Files 2510 2512 +2
Lines 71194 71137 -57
Branches 8973 8946 -27
==========================================
+ Hits 50117 50134 +17
+ Misses 18883 18809 -74
Partials 2194 2194
Flags with carried forward coverage won't be shown. Click here to find out more.
|
useInstrumentsQuery, | ||
} from '@opentrons/react-api-client' | ||
LEFT, | ||
MotorAxes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
import type { MotorAxes } from '@opentrons/shared-data'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The frontend part looks good to me.
For Deck Configuration part, waiting for Brent's review would be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSS stuff should be good. From the commit logs, I don't think there's been an opportunity for much conflict.
Overview
Merge 7.1.0 back into edge so the changes with the latest drop tip command are in Protocol Designer.