implement feedback; line edits #33383
Workflow file for this run
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # This workflow runs checks (types, formatting, style) for our js projects | |
| # which cannot be meaningfully separated | |
| name: 'JS checks' | |
| on: | |
| pull_request: | |
| paths: | |
| - '**/*.js' | |
| - './.*.js' | |
| - '**/*.ts' | |
| - '**/*.tsx' | |
| - '**/*.json' | |
| - '**/*.css' | |
| - '**/*.md' | |
| push: | |
| paths: | |
| - '**/*.js' | |
| - './.*.js' | |
| - '**/*.ts' | |
| - '**/*.tsx' | |
| - '**/*.json' | |
| - '**/*.md' | |
| - '.github/workflows/js-check.yaml' | |
| - '**/*.css' | |
| workflow_dispatch: | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}-${{ github.ref_name != 'edge' || github.run_id}}-${{ github.ref_type != 'tag' || github.run_id }} | |
| cancel-in-progress: true | |
| defaults: | |
| run: | |
| shell: bash | |
| env: | |
| CI: true | |
| jobs: | |
| checks: | |
| name: 'js checks' | |
| runs-on: 'ubuntu-22.04' | |
| timeout-minutes: 20 | |
| steps: | |
| - uses: 'actions/checkout@v3' | |
| - uses: 'actions/setup-node@v3' | |
| with: | |
| node-version: '18.19.0' | |
| - name: 'set complex environment variables' | |
| id: 'set-vars' | |
| uses: actions/github-script@v6 | |
| with: | |
| script: | | |
| const { buildComplexEnvVars } = require(`${process.env.GITHUB_WORKSPACE}/.github/workflows/utils.js`) | |
| buildComplexEnvVars(core, context) | |
| - name: 'install libudev for usb-detection' | |
| run: sudo apt-get update && sudo apt-get install libudev-dev | |
| - name: 'cache yarn cache' | |
| uses: actions/cache@v3 | |
| with: | |
| path: | | |
| ${{ github.workspace }}/.yarn-cache | |
| ${{ github.workspace }}/.npm-cache | |
| key: js-${{ secrets.GH_CACHE_VERSION }}-${{ runner.os }}-yarn-${{ hashFiles('yarn.lock') }} | |
| restore-keys: | | |
| js-${{ secrets.GH_CACHE_VERSION }}-${{ runner.os }}-yarn- | |
| - name: 'setup-js' | |
| id: 'setup-js' | |
| run: | | |
| npm config set cache ${{ github.workspace }}/.npm-cache | |
| yarn config set cache-folder ${{ github.workspace }}/.yarn-cache | |
| make setup-js | |
| # Use the if to run all the lint checks even of some fail | |
| shell: bash | |
| - name: 'lint js' | |
| if: always() && steps.setup-js.outcome == 'success' | |
| run: make lint-js | |
| - name: 'typechecks' | |
| if: always() && steps.setup-js.outcome == 'success' | |
| run: make check-js | |
| - name: 'circular deps' | |
| if: always() && steps.setup-js.outcome == 'success' | |
| run: make circular-dependencies-js | |
| - name: 'lint json' | |
| if: always() && steps.setup-js.outcome == 'success' | |
| run: make lint-json | |
| - name: 'lint css' | |
| if: always() && steps.setup-js.outcome == 'success' | |
| run: make lint-css | |
| - name: 'test scripts' | |
| run: yarn jest scripts |